Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TX flow] Display Token balance #2155

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[TX flow] Display Token balance #2155

merged 2 commits into from
Jun 22, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jun 22, 2023 •
edited
Loading

How this PR fixes it

  • Displays the token balance in the amount input field
  • Slightly decreases the spacing of the amount input as discussed here

How to test it

  1. Open the Safe
  2. Create a new transaction
  3. Observe the token balance is visible

Screenshots

Screenshot 2023-06-22 at 15 32 36 Screenshot 2023-06-22 at 15 32 43

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://token_balance--walletweb.review-wallet-web.5afe.dev

@usame-algan usame-algan changed the base branch from dev to epic-tx-flow June 22, 2023 13:33
@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

iamacook
iamacook reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the alignment of the max button and the token selector. I would suggest making the max button a little bit taller so they are the same height.

@usame-algan
Copy link
Member Author

Looks good apart from the alignment of the max button and the token selector. I would suggest making the max button a little bit taller so they are the same height.

I slightly decreased the spacing and line-height to get it back to the same size instead since its closer to the design (50px height button)

@usame-algan usame-algan merged commit ccf93fd into epic-tx-flow Jun 22, 2023
@usame-algan usame-algan deleted the token-balance branch June 22, 2023 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usame-algan @iamacook